how long does it takes to establish good credit?

i'm trying to clear up my past debts and look at my credit report, I notice that past things haven't fall off yet and it's past 7 years. I'm w/ paying my bills on time, especially credit card bills and I only use them for emergencies. am i'm heading in the right direction or am i'm doing something wrong. Please help